Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make warning optional #85

Merged
merged 1 commit into from Jan 9, 2019
Merged

Make warning optional #85

merged 1 commit into from Jan 9, 2019

Conversation

Koreil
Copy link
Collaborator

@Koreil Koreil commented Nov 28, 2018

No description provided.

@Koreil
Copy link
Collaborator Author

Koreil commented Nov 28, 2018

cc @Yeti-or

@coveralls
Copy link

coveralls commented Nov 28, 2018 •
edited

Coverage Status

Coverage decreased (-3.0%) to 89.441% when pulling e667e72 on koreil.optional-warning into 8c0719f on master.

@yarastqt
Copy link
Member

yarastqt commented Jan 9, 2019

Давайте довливаем этот ПР, только бы не плохо добавить emitWarning вместо emitError, т.к. из-за этого webpack завершает работу с кодом 2 и сборка в CI не выполняется.

@yarastqt yarastqt merged commit 1aea0d7 into master Jan 9, 2019
@yarastqt yarastqt deleted the koreil.optional-warning branch January 9, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qfox qfox qfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Koreil @coveralls @yarastqt @qfox