You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think I may found a bug where a value of false for -unique will trigger the case statement for enabling unique message deduplication.
When using -unique=false I am getting deduped results. This may seem like a silly test since the default is false. I came across this by using the metermon project which sets this to true by default, Overriding the value with the rtlamr_unique env variable to false did not have the desired affect. So I tested rtlamr directly and found that setting the flag to false still dedupes.
I also recreated the issue with the latest bemasher/rtlamr docker hub image.
The text was updated successfully, but these errors were encountered:
You are correct. In go's standard flags package, boolean flags don't need to be specified with a value, so the current logic only checks for existence of the flag. See below.
I see where it may be useful to always specify a flag and instead change the value passed when controlling rtlamr with another process. Luckily, the fix is easy, I'll work on it.
bemasher
changed the title
Possible issue with unique flag logic?
Boolean flags ignore value
Jun 17, 2021
I think I may found a bug where a value of false for -unique will trigger the case statement for enabling unique message deduplication.
When using -unique=false I am getting deduped results. This may seem like a silly test since the default is false. I came across this by using the metermon project which sets this to true by default, Overriding the value with the rtlamr_unique env variable to false did not have the desired affect. So I tested rtlamr directly and found that setting the flag to false still dedupes.
I also recreated the issue with the latest bemasher/rtlamr docker hub image.
The text was updated successfully, but these errors were encountered: