Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default headers to configuration #44

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

rafaeljusto
Copy link
Contributor

The dynamic values could be found in the HTTP headers (e.g. Etag). This new
configuration entry will work on the same way of the current defaults, but
being applied to the header instead of the JSON body.

Resolves #43

The dynamic values could be found in the HTTP headers (e.g. Etag). This new
configuration entry will work on the same way of the current defaults, but
being applied to the header instead of the JSON body.

Resolves beme#43
@rafaeljusto
Copy link
Contributor Author

Travis failed on Go 1.9 due to some network issue, couldn't restart the build to see the green lights 😄

screen shot 2018-08-14 at 16 37 51

@sjkaliski
Copy link
Collaborator

@rafaeljusto thanks for the contribution! I'm wondering if there is any harm / incompatibility with just including this all in defaults?

@rafaeljusto
Copy link
Contributor Author

Nop, no harm at all. Just I thought it was cleaner to keep headers and content defaults on different places. Unless there's a match for a header and JSON field such as:

GET /example HTTP/1.1
Host: i.want.to.be.overwrite

{
  "Host": "I don't want to be overwrite",
}

@rafaeljusto
Copy link
Contributor Author

@sjkaliski Updated the PR to also get the HTTP headers from the defaults section.

@sjkaliski sjkaliski merged commit 1966219 into beme:master Aug 22, 2018
@sjkaliski
Copy link
Collaborator

@rafaeljusto thanks! 🎉

@rafaeljusto rafaeljusto deleted the enhancement/config-http-headers branch August 24, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants