Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #94

Closed
14 tasks done
mscroggs opened this issue Jan 19, 2021 · 9 comments · Fixed by #95
Closed
14 tasks done

JOSS paper #94

mscroggs opened this issue Jan 19, 2021 · 9 comments · Fixed by #95

Comments

@mscroggs
Copy link
Member

mscroggs commented Jan 19, 2021

Checklist of things that need doing. These are in progress in the mscroggs/joss branch.

From jamtrott's review:

  • (i) "there is lack of comparison to other software for solving boundary integral equations"
  • (ii) "I think the paper could benefit from a little more background, such as an example of the type of equations that are relevant."
  • (xiv) "The statement of need could benefit from a short discussion or mention of why they choose to use OpenCL and numba for just-in-time compilation."

From ramisetti's review:

  • (iii) "The documentation claims the software can import and export in a number of formats, including Gmsh and VTK but it is not clearly evident from the examples provided in the applications section, except the exporting of gmsh file in the second example. The authors should provide at least one example for each case."
  • (iv) "Similarly, the authors should provide examples on the CPU and GPU parallelisation."
  • (v) "The documentation for the examples should place a phrase related to the functionality to help the users understand the purpose of the example. For example, the documentation for each example can mention a phrase about the functionality in brackets beside the link"
  • (vi) "The authors may consider mentioning about the target audience of this software to make it more clear to the potential users"
  • (vii) "The authors may consider mentioning the versions of the dependencies particularly for gmsh as this could save time for users in installing the dependencies"
  • (viii) "The authors should fix the broken link for “Weakly imposing a Dirichlet boundary condition” example."
  • (ix) "I would recommend to separate the tutorials from documentation as it is more intuitive to find examples in tutorials section rather in documentation"
  • (x) "The python core functionality documentation is available through few links, but I believe it is not up to a satisfactory level to be useful for the prospective software developers interested in the software. The documentation should explicitly provide a link to API documentation"
  • (xi) "Although the repository contains a list of unit test but the documentation does not mention anything about any automated tests. The authors should consider updating the documentation with information on unit tests"
  • (xii) "Information on third party contribution to the software is not provided."
  • (xiii) "This submission lacks information on why this software is better and how this compares to any of the existing open source software. The authors should consider including information in the paper if there are any existing other opensource software and how this software compares with them."

Notes on these changes are in the replies below. Some of these changes will only happen once the branch has been merged

@mscroggs
Copy link
Member Author

mscroggs commented Jan 19, 2021

(iii) VTK export alternative is added to the example, and a link is added to the mesh export part of the Handbook

@mscroggs
Copy link
Member Author

(ix) and (v) tutorials moved to https://bempp.com/documentation/tutorials.html and one sentence descriptions added

@mscroggs
Copy link
Member Author

(vii) Version number for Gmsh has been added to https://bempp.com/installation.html. All the other dependencies are tested against latest releases

@mscroggs
Copy link
Member Author

(x) More docstrings have been added, and links between the Read the Docs and the Handbook have been added

@mscroggs
Copy link
Member Author

(iv) Snippets showing how to do this have been added to the Handbook. Longer term, we are planning to write a tutorial showing off GPU and CPU functionality.

@mscroggs
Copy link
Member Author

Useful link to diff of md and bib files to see what has changed in paper: https://github.com/bempp/bempp-cl/pull/95/files?file-filters%5B%5D=.bib&file-filters%5B%5D=.md

@mscroggs
Copy link
Member Author

Information about how to run tests has been added to readme

@mscroggs
Copy link
Member Author

CONTRIBUTING.md has been added

@mscroggs
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant