Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Replace updeep with immer #704

Closed
dtinth opened this issue Oct 17, 2021 · 6 comments
Closed

Refactoring: Replace updeep with immer #704

dtinth opened this issue Oct 17, 2021 · 6 comments

Comments

@dtinth
Copy link
Member

dtinth commented Oct 17, 2021

Background

Bemuse used the updeep library, but after some experience in other projects I think using immer leads to more readable code.

Task

  • Replace updeep with immer.
  • Your PR should migrate all usage of code that uses updeep and replace it with immer. In bemuse/package.json, updeep should be removed from dependencies, and latest version of immer added.
  • All automated checks should pass.

Hacktoberfest

If you would like to work on this task, please write a comment stating your intent. We will then assign the issue to you. To ensure continuity, the issue will be unassigned after 3 days of inactivity — so please keep us updated.

@aadityasinha-dotcom
Copy link

Can I work on this issue?

@dtinth
Copy link
Member Author

dtinth commented Oct 17, 2021

@aadityasinha-dotcom The issue is now yours, thank you! 🙏

@aadityasinha-dotcom
Copy link

@dtinth I have added the latest version of immer in the bemuse/package.json and removed the updeep from the dependencies.

@dtinth
Copy link
Member Author

dtinth commented Oct 20, 2021

@aadityasinha-dotcom I see that the PR is closed — do you plan to continue this some time or should I unassign this for now?

@aadityasinha-dotcom
Copy link

aadityasinha-dotcom commented Oct 20, 2021

@aadityasinha-dotcom I see that the PR is closed — do you plan to continue this some time or should I unassign this for now?

No, I am working on it. Actually that was an incomplete PR so I thought to close that.

@dtinth
Copy link
Member Author

dtinth commented Oct 20, 2021

@aadityasinha-dotcom Thanks for the update! Let me know if you need any help. 😃

You can mark your PR as “draft” so that it is clear that the PR is not ready yet.

This was referenced Oct 24, 2021
@aadityasinha-dotcom aadityasinha-dotcom removed their assignment Mar 6, 2022
@dtinth dtinth closed this as completed in 52c9bec Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants