Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GitHub Actions workflow to build Bemuse based on CircleCI config #757

Closed
dtinth opened this issue Oct 15, 2022 · 3 comments · Fixed by #762
Closed

Create a GitHub Actions workflow to build Bemuse based on CircleCI config #757

dtinth opened this issue Oct 15, 2022 · 3 comments · Fixed by #762

Comments

@dtinth
Copy link
Member

dtinth commented Oct 15, 2022

Background

We already have build automation using CircleCI, but I also would like the project to be built on GitHub Actions.

Task

  • Implement a GitHub Actions build pipeline based on the current CircleCI pipeline.
    • This build workflow should do this:
      • Build Bemuse
      • Upload the dist folder as an artifact
    • Do not need to run any tests or any deployment steps — they will still be done on CircleCI for now.
  • Your PR should create one new file, .github/workflows/ci.yml
  • Please include a screenshot in your PR to confirm that it is working.

Hacktoberfest

If you would like to work on this task, please write a comment stating your intent. We will then assign the issue to you. To ensure continuity, the issue will be unassigned after 3 days of inactivity — so please keep us updated.

Getting assigned to an issue is NOT a reservation. It is simply to let others know that someone is already working on it to avoid duplicated efforts. The first person who submits a valid Pull Request (PR) that resolves the issue will have their PR merged, regardless of who was assigned to the issue. However, if you are assigned to an issue and start working on it, but someone else submits a valid PR before you, you can still submit a valid PR even if it has conflicts. The PR will be given the "hacktoberfest-accepted" label and the issue will be closed.

If you encounter any problem, please include relevant logs and screenshot so it’s easy to troubleshoot.

@doublevcodes
Copy link
Contributor

Hello, I would like to work on this

@doublevcodes
Copy link
Contributor

I'm working on this and I encounter the following error.
Screenshot 2022-10-15 at 17 42 17

I'm not sure how to fix it: https://github.com/doublevcodes/bemuse/actions/runs/3256353254/jobs/5346707308

@dtinth
Copy link
Member Author

dtinth commented Oct 15, 2022

@doublevcodes Sorry, it seems that one of our dependencies is outdated.

I just fixed it right now. Please update your PR atop latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants