Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp-sourcemaps support #4

Closed
zslabs opened this issue Nov 11, 2014 · 7 comments
Closed

Gulp-sourcemaps support #4

zslabs opened this issue Nov 11, 2014 · 7 comments

Comments

@zslabs
Copy link

zslabs commented Nov 11, 2014

Any chance of adding in gulp-sourcemaps support? Would love to bundle this in. Thanks!

@ben-eb
Copy link
Owner

ben-eb commented Nov 11, 2014

I'm not familiar with this, to be honest. Does it require that sourcemaps be available in the underlying library? If so there is an open issue for it, over here.

Or is it the case where you can generate the sourcemap directly in the vinyl stream? I'm a little bit out of the loop with this library! 😃 If so, 👍 - if you know of an implementation and can send a PR, that'd be really good.

@zslabs
Copy link
Author

zslabs commented Nov 16, 2014

Ah k, may be related to the other one. It looks "in theory" that it's a rather small snippet to add; as outlined in their Plugin developers only: How to add source map support to plugins section, but I'll defer to you on that ;)

@ben-eb
Copy link
Owner

ben-eb commented Dec 13, 2014

👍 on sourcemaps but I'm not familiar enough with the source-map library (which is for JS, can it do CSS too?) to add this feature upstream. You will notice on the wiki page for gulp-sourcemaps that plugins that expose this functionality are delegating to their underlying libraries, as I would have to do here. So, it's not a case of simply adding the feature to this module, that ability needs to be added into CSSO itself.

If someone has the capability to add this feature upstream then that'd be awesome.

/cc @MetaDriver

@yocontra
Copy link
Contributor

+1 - I'll post on the csso issue and bug them

@MetaDriver
Copy link

  18.12.2014, 07:43, "Eric Schoffstall" notifications@github.com:+1 - I'll post on the csso issue and bug them—Reply to this email directly or view it on ОK.  It's well.  Thank you.My english is very bad for similar description.

@ben-eb
Copy link
Owner

ben-eb commented Jul 16, 2015

Closing as csso has no active maintainers.

@ben-eb
Copy link
Owner

ben-eb commented Feb 27, 2016

@ben-eb ben-eb reopened this Feb 27, 2016
@ben-eb ben-eb closed this as completed in 2b02b1f Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants