make plugin work for multi-module android project with flatDirs #59
Conversation
|
Thanks! What are the benefits between this approach and ignoring flatDir repositories? I can think of two possible ones. First that when dependency was unresolved, due to ignoring the repository, there was no exceptional cause and thus no clear reason given in the log. That may have been partially due to the logging bug you fixed. The other is that even though flatDir repositories lack metadata, the version may be inferred by the dependency name. This may make the dependency comparable against a version found in an external repository and provide meaningful update information. I'm not sure if this is what Gradle will actually due, though. |
|
I was still ending up with NPE's when run against our project. I think hiding the flatDir repos wasn't actually hiding the dependencies. |
The test fails with my fix for #36, which passed the provided example project, due to an NPE using the comparator. The test passes with the fix provided by #59, validating @dbachelder's solution.
|
Thanks! I wrote a unit test that reproduced the NPE, which your changes fix. @jochenberger Please perform a release when you have the time. |
some quick fixes to get things working for our project... not sure if you want these changes or not...