Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arbitrary variants #546

Merged
merged 1 commit into from
Oct 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions __fixtures__/arbitraryVariants/arbitraryVariants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import tw from './macro'

tw`[section]:hover:block`

tw`[p]:hover:block`
tw`hover:[p]:block`

tw`[* + *]:block` // Spaces
tw`[.class1 .class2]:block` // Classes

tw`[.class1]:[.class2]:block` // Multiple dynamic variants
tw`[.class1 .class2]:[.class3]:block` // Multiple dynamic variants

tw`[p]:placeholder-red-500/[var(--myvar)]`
tw`[p]:mt-[var(--myvar)]`
tw`[p]:marginTop[var(--myvar)]`

tw`[p]:(mt-4 mb-4)`
99 changes: 99 additions & 0 deletions __snapshots__/plugin.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3111,6 +3111,105 @@ tw\`md:text-[red]\`
})


`;

exports[`twin.macro arbitraryVariants.js: arbitraryVariants.js 1`] = `

import tw from './macro'

tw\`[section]:hover:block\`

tw\`[p]:hover:block\`
tw\`hover:[p]:block\`

tw\`[* + *]:block\` // Spaces
tw\`[.class1 .class2]:block\` // Classes

tw\`[.class1]:[.class2]:block\` // Multiple dynamic variants
tw\`[.class1 .class2]:[.class3]:block\` // Multiple dynamic variants

tw\`[p]:placeholder-red-500/[var(--myvar)]\`
tw\`[p]:mt-[var(--myvar)]\`
tw\`[p]:marginTop[var(--myvar)]\`

tw\`[p]:(mt-4 mb-4)\`

↓ ↓ ↓ ↓ ↓ ↓

;({
section: {
':hover': {
display: 'block',
},
},
})
;({
p: {
':hover': {
display: 'block',
},
},
})
;({
':hover': {
p: {
display: 'block',
},
},
})
;({
'* + *': {
display: 'block',
},
}) // Spaces

;({
'.class1 .class2': {
display: 'block',
},
}) // Classes

;({
'.class1': {
'.class2': {
display: 'block',
},
},
}) // Multiple dynamic variants

;({
'.class1 .class2': {
'.class3': {
display: 'block',
},
},
}) // Multiple dynamic variants

;({
p: {
'::placeholder': {
color: 'rgba(239, 68, 68, var(--myvar))',
},
},
})
;({
p: {
marginTop: 'var(--myvar)',
},
})
;({
p: {
marginTop: 'var(--myvar)',
},
})
;({
p: {
marginTop: '1rem',
marginBottom: '1rem',
},
})


`;

exports[`twin.macro autoCssProp.js: autoCssProp.js 1`] = `
Expand Down
21 changes: 17 additions & 4 deletions src/variants.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ const validateVariants = ({ variants, state, ...rest }) => {
if (isResponsive) return stringifyScreen(state.config, variant)

let foundVariant = fullVariantConfig[variant]

if (!foundVariant) {
const arbitraryVariant = variant.match(/^\[(.+)]/)
if (arbitraryVariant) foundVariant = arbitraryVariant[1]
}

if (!foundVariant) {
if (variant === 'only-child') {
throw new MacroError(
Expand Down Expand Up @@ -87,10 +93,14 @@ const splitVariants = ({ classNameRaw, state }) => {
let variant
let className = classNameRaw
while (variant !== null) {
variant = className.match(/^([\d_a-z-]+):/)
// Match arbitrary variants
variant = className.match(/^([\d_a-z-]+):|^\[.*?]:/)

if (variant) {
className = className.slice(variant[0].length)
variantsList.push(variant[1])
variantsList.push(
variant[0].slice(0, -1).replace(new RegExp(SPACE_ID, 'g'), ' ')
)
}
}

Expand Down Expand Up @@ -214,7 +224,8 @@ function spreadVariantGroups(
const results = []
classes = classes.slice(start, end).trim()

const reg = /([\w-]+:)|([\w-./[\]]+!?)|\(|(\S+)/g
// variant / class / group
const reg = /(\[.*?]:|[\w-]+:)|([\w-./[\]]+!?)|\(|(\S+)/g

let match
const baseContext = context
Expand All @@ -223,7 +234,9 @@ function spreadVariantGroups(
const [, variant, className, weird] = match

if (variant) {
context += variant
// Replace arbitrary variant spaces with a placeholder to avoid incorrect splitting
const spaceReplacedVariant = variant.replace(/\s+/g, SPACE_ID)
context += spaceReplacedVariant

// Skip empty classes
if (/\s/.test(classes[reg.lastIndex])) {
Expand Down