Add support for styled-components v6 #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-rogerson
force-pushed
the
feature/styled-components-6-support
branch
from
dc5c6c9
to
206c024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for styled-components v6 by setting the
sassyPseudooption to true for the styled-components preset.Prefixing selectors like hover with an ampersand (eg:
&:hover) were made a requirement in the latest version.Another change is that when using styled, all props will be added to the element and you'll likely see a console warning. This isn't handled by twin so we'll need to use transient props to get around that.
Related #805