Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors under Embarcadero C++ compiler #33

Closed
mmaraya opened this issue Dec 29, 2016 · 1 comment
Closed

Compile errors under Embarcadero C++ compiler #33

mmaraya opened this issue Dec 29, 2016 · 1 comment

Comments

@mmaraya
Copy link
Contributor

mmaraya commented Dec 29, 2016

Thanks for this library and it works great under macOS/LLVM. I do have a need to run this library under Win32 and for reasons I won't go into here, I'm using a free C++11 compiler from Embarcadero (Borland C++ in my youth). bcc32c reports the following errors:

include\fast-cpp-csv-parser/csv.h:236:52: error: use of overloaded operator '!=' is ambiguous
(with operand types 'const std::unique_ptr<ByteSourceBase>' and 'int')
                                return byte_source != 0;
include\fast-cpp-csv-parser/csv.h:262:48: error: use of overloaded operator '!=' is ambiguous
(with operand types 'std::unique_ptr<ByteSourceBase>' and 'int')
                                if(byte_source != 0){
include\fast-cpp-csv-parser/csv.h:296:52: error: use of overloaded operator '!=' is ambiguous 
(with operand types 'const std::unique_ptr<ByteSourceBase>' and 'int')
                                return byte_source != 0;

Any thoughts or insights?

@ben-strasser
Copy link
Owner

ben-strasser commented Dec 29, 2016 via email

ben-strasser added a commit that referenced this issue Jan 3, 2017
Updated pointer checks to use C++11 nullptr, fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants