Replace String with OsString in get_shell_item_display_name
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string which `get_shell_item_display_name` extracts may contain malformed UTF-16. `OsString` can handle malformed UTF-16 losslessly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string which
get_shell_item_display_nameextracts may contain malformed UTF-16.OsStringcan handle malformed UTF-16 losslessly.I encountered a panic due to the
.unwrap()on line 541 while testing the correctness of the changes made to balthild/native-dialog-rs in response to native-dialog-rs/native-dialog-rs#3. The code used to trigger the panic can be found here.