Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker compose example #54

Merged
merged 6 commits into from
Feb 9, 2022
Merged

Conversation

ben-xo
Copy link
Owner

@ben-xo ben-xo commented Feb 5, 2022

No description provided.

Copy link

@karawitan karawitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid the following error, I'd suggest
-version: "3.9"
+version: "2.3"

docker-compose up -d
ERROR: Version in "./docker-compose.yml" is unsupported. You might be seeing this error because you're using the wrong Compose file version. Either specify a supported version (e.g "2.2" or "3.3") and place your service definitions under the services key, or omit the version key and place your service definitions at the root of the file to use version 1.

Copy link

@karawitan karawitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volume for /var/www/html is shared for both web and php-fpm services, would be nice to have a single declaration for volume :)

Copy link

@karawitan karawitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% working , approved ! many thanks

@ben-xo ben-xo merged commit e6ff764 into master Feb 9, 2022
@ben-xo ben-xo deleted the feature/docker-compose-example branch February 9, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants