Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns2.1 and TryResolveStateMachineMethod #125

Merged
merged 11 commits into from
Jan 3, 2021
Merged

ns2.1 and TryResolveStateMachineMethod #125

merged 11 commits into from
Jan 3, 2021

Conversation

bruno-garcia
Copy link
Contributor

@bruno-garcia bruno-garcia commented Jan 3, 2021

it's an easy change to discuss while looking at the change.

  • Makes sense to have ns2.1?
  • The goal is to add AsyncIteratorStateMachineAttribute

Nice CI is there! 🚀

@benaadams
Copy link
Owner

Feature 'nullable reference types' is not available in C# 7.3. Please use language version 8.0 or greater.
Feature 'static local functions' is not available in C# 7.3. Please use language version 8.0 or greater.

Is lang latest conditional based on TFM?

@bruno-garcia
Copy link
Contributor Author

bruno-garcia commented Jan 3, 2021

It "works on my machine" as it builds here.
I assume it requires net5 installed.

I see CI has it:

      - name: Install .NET SDK 5.0
        uses: actions/setup-dotnet@v1
        with:
          dotnet-version: '5.0.x'

@bruno-garcia
Copy link
Contributor Author

I'll remove it

@bruno-garcia
Copy link
Contributor Author

Oddly enough only failed on Ubuntu

Directory.Build.props Outdated Show resolved Hide resolved
@benaadams
Copy link
Owner

I'm going to check my casing in another project I have that was having the same issue with nullability 😅

@benaadams
Copy link
Owner

Also a test to show its doing something? (Resolving the Iterator)

<PropertyGroup>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' != 'netstandard2.0' and !$(TargetFramework.StartsWith('netcoreapp2')) and !$(TargetFramework.StartsWith('net4'))">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding net6 or any other tfm in the future would include HAS_ASYNC_ENUMERATOR without anyone having to remember opting-in.

README.md Outdated Show resolved Hide resolved
@benaadams benaadams merged commit c502ee9 into benaadams:master Jan 3, 2021
@benaadams
Copy link
Owner

Thank you :)

@bruno-garcia bruno-garcia deleted the feat/ns2.1-runtime-TryResolveStateMachineMethod branch January 3, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants