Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new localized fields #160

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TheBug233
Copy link
Contributor

No description provided.

@benaclejames benaclejames self-requested a review July 31, 2023 19:10
Copy link
Owner

@benaclejames benaclejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though some small changes and issues

Not sure what happened, but the settings page appears to freak out at smaller window sizes with this PR

image

Comment on lines +392 to +393
<data name="Receive_Port.Description" xml:space="preserve">
<value>This port is used to receive OSC data from VRChat</value>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need descriptions for these values

Comment on lines +413 to +415
<data name="Send_Port.Description" xml:space="preserve">
<value>⚠no other program occupying the port</value>
</data>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need descriptions for these values

Comment on lines +380 to +382
<data name="IP_Address.Description" xml:space="preserve">
<value>No changes required to run VRChat localhost</value>
</data>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need descriptions for these values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants