Skip to content

Commit

Permalink
ndi: unpackPhase without interpolation of src
Browse files Browse the repository at this point in the history
The `unpackPhase` as of the previous commit did interpolate the result of the `src` on a nix level.
However for any overrides (`overrideAttrs`) to work on the source, for instance to update to a newer version locally, the `src` environment variable of `stdenv` must be used.
Otherwise the old, upstream, version will still be pulled in as a dependency and ultimately used for building, which will fail if the old version is not present, or will just deploy the old version if the old version was already downloaded (`requireFile` causes special semi-non-idempotent issues here).

Further information was provided in a GitHub comment: NixOS#219578 (comment)

Signed-off-by: benaryorg <binary@benary.org>
  • Loading branch information
benaryorg committed Jun 11, 2023
1 parent 7cce8b1 commit 6b74da4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/development/libraries/ndi/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ stdenv.mkDerivation rec {
buildInputs = [ avahi ];

unpackPhase = ''
unpackFile ${src}
unpackFile $src
echo y | ./${installerName}.sh
sourceRoot="NDI SDK for Linux";
'';
Expand Down

0 comments on commit 6b74da4

Please sign in to comment.