Add ConnectivityResponseValidator protocol and customValidator property #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
commented
Oct 12, 2019
| // Abort early if enough tasks have completed successfully | ||
| self?.cancelConnectivityCheck(pendingTasks: tasks, successfulChecks: successfulChecks, | ||
| totalChecks: totalChecks) | ||
| let completionHandlerForUrl: (URL) -> ((Data?, URLResponse?, Error?) -> Void) = { url in |
There was a problem hiding this comment.
To include the URL in response validation, the signature here was updated to require passing the URL, so that it could be captured and included when moving on to response validation
benasher44
commented
Oct 12, 2019
| @@ -0,0 +1,60 @@ | |||
| // | |||
| // ConnectivityResponseValidation.swift | |||
There was a problem hiding this comment.
I'll fix the filename in the new PR
benasher44
commented
Oct 12, 2019
| matchesRegularExpression | ||
| } | ||
|
|
||
| public class ConnectivityResponseStringTestValidator: ConnectivityResponseValidator { |
There was a problem hiding this comment.
This class is the old validator renamed and given a public API
benasher44
commented
Oct 12, 2019
| @@ -300,15 +305,31 @@ private extension Connectivity { | |||
| } | |||
|
|
|||
| /// Determines whether or not the connectivity check was successful. | |||
| private func connectivityCheckSucceeded(data: Data?) -> Bool { | |||
| guard let data = data, let responseString = String(data: data, encoding: .utf8) else { | |||
There was a problem hiding this comment.
This was moved into the validator
benasher44
force-pushed
the
basher/custom-validation
branch
from
3f24d5d
to
fd36cf2
Compare
|
Closing this to reopen against main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of rwbutler#26. I'll open a new PR with tests after some discussion + resolving rwbutler#27.