-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Hierarchical Projects (HMPP) support #110
Comments
My understanding was that this doesn't work for user-defined libraries yet: https://youtrack.jetbrains.com/issue/KT-40975. Though, JuulLabs/kable's test PR seems to prove otherwise. Will this break non-HMPP consumers of 1.4+? |
Regardless, given how close we are to 1.4.30 release, I think I'll include support for this in the 1.4.30 release |
My understanding is that it is backwards compatible (or at least there is another flag that can make it backwards compatible). If I can find the time, I'll try to look into this to confirm and see if I can find the flag that I'm thinking of. |
I asked Kotlin folks, and the "compatibility variant" needs to be enabled to support non-HMPP clients. Here's an example: https://github.com/ktorio/ktor/blob/master/gradle.properties#L80-L81 They're working on correcting the docs for this. |
Nice! You beat me to it. I found a kotlinlang Slack thread that also discusses the |
FYI I currently don't have any of this stuff enabled in Multiplatform Settings largely because the 1.4.20 release blog mentioned better compatibility with people on older Kotlin versions or who don't enable hmpp themselves if it's disabled in the library https://blog.jetbrains.com/kotlin/2020/11/kotlin-1-4-20-released/#updated-structure-of-multiplatform-library-publications Because I never had a reply in that Slack thread, I don't know whether |
|
Should be fixed in 0.2.4 |
Similar to touchlab/Stately#46, HMPP is needed in order for downstream consumers of this library to enable HMPP.
See JuulLabs/kable#63 as an example (failed) attempt to enable HMPP downstream of this library.
The text was updated successfully, but these errors were encountered: