Bump Gradle and Dokka #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Jul 14, 2023
| path = kotlin.sourceSets.mingwMain.kotlin.srcDirs[0] | ||
| platforms = ['native'] | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not 100% sure if this is still needed. Since the Dokka version was quite old, I assumed the newer version maybe handle that part better but let me know if not the case.
There was a problem hiding this comment.
I'm not 100% sure here, but I'll take a look at the output!
|
The downstream PR is merged. Mind updating with master? |
martinbonnin
force-pushed
the
bump-gradle
branch
from
b8afddc
to
06c75d1
Compare
|
I have a few release tasks I need to sit down and do. I'll make this part of that, when I do it in the next few days! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ended up bumping Dokka as well because the older Dokka version wasn't compatible with Gradle 8