-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature requests and suggestions #17
Comments
Love what you have here. My two cents on watch mode: I feel like this package should be part of a git workflow and not watch mode at all. I would personally use this package only after my tree is clean and I'm about to push. Similar to how yarn publish will auto commit the bump of a version number in Config files are gross, but what other options are there? We could just put them inline as CLI args in |
@waynevanson I agree and think one of the major issues we need to solve is how to use I do not really envision |
@sQVe I just added to my comment if you'd like to see more.
Yeah that looks like a huge pain. I wonder what will be the solution. In teams, it would be harder to use on an automatic basis. I agree with you. |
We are using |
There will be conflicts if the team/individual use
Also, I completely agree that probably there should not be a watch mode. Watch mode complicates things a lot and might not really be useful in most of the cases. |
@ganapativs What would be the sequence of steps to replicate the conflict? Are you thinking: |
This probably should work(Needs testing) User 1 git moves the file(say in fresh branch-1 from the master) Optionally, User 2 should get conflicts if User 1 changes are squashed and merged first. This happened to me many times in large PRs, I expect it to happen here also. |
@ganapativs Squashing is not relevant in your example. Squashing problems will occur when you branch from a commit that later in time gets squashes - for example a feature branch that is based on another feature branch. What your example is explaining is just a simple merge conflict due to two parts changing the same thing. This is nothing that we'll be able to solve and will have to be handled manually. What we do is make the merge conflicts easier by marking moved files as moved in Git. |
This tool has great potential. Here are some features I could think of.
Resolving multiple files with the same extension(Not sure if it's already supported)
If a folder has
.js
and.jsx
and has been imported without extension, resolve order matters here. Make it configurable, optionally usebutler.config.js
?Watch mode?
Dry run
Potentially there will be too many folders/files movement, this might not be what the user always wants by default. There should be a way to see what happens before it actually happens. I could think of two options(Note: we already have information about this in the graph).
These features are already suggested, but, re-adding here with a bit more context.
Ignore directories/files/regex pattern
Some tools like
next.js
andGatsby
depend on the folder structure. Allow skipping some of the folders and files(Ignore-rules #11)Support running programmatically
Allow running via node(or any other tool) for flexibility. also, we might need some sort of config file like
butler.config.js
(oh, no, another config file?)(config file and flags #8)We can also have a GitHub project board where we can track progress. I'm really excited about the future of this project 🎉
The text was updated successfully, but these errors were encountered: