Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config file and flags #8

Closed
AnatoleLucet opened this issue Feb 14, 2020 · 3 comments
Closed

config file and flags #8

AnatoleLucet opened this issue Feb 14, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@AnatoleLucet
Copy link
Collaborator

AnatoleLucet commented Feb 14, 2020

As mentioned in #3, it could be nice to have some options. Either with some flags in the cli or a config file.

Here's some of my obvious ideas when we speak about options for a cli:

  • Ignored pattern & files/folders names. For example: butler-cli src --ignore *.js ingore js files
  • Some kind of regex (like ESLint is doing) for the first argument which is the path. For example butler-cli src/**/*.{ts, tsx} would only apply changes to .ts & .tsx files.

Any thought?

@nmay231
Copy link

nmay231 commented Feb 14, 2020

Another config option that would be useful is the file path separator, whether it is forwards slash "/", back slash "\", or inferred (default).

Also, having the ability to leave a comment at the top of the file /* butler-ignore */ would be helpful in some cases. But that opens a whole other can of worms 😉

@benawad
Copy link
Owner

benawad commented Feb 14, 2020

I'm thinking of using https://github.com/davidtheclark/cosmiconfig for getting the config file

and https://github.com/tj/commander.js/ to handle flags

@AnatoleLucet AnatoleLucet added the enhancement New feature or request label Feb 16, 2020
This was referenced Feb 20, 2020
@sQVe
Copy link
Collaborator

sQVe commented Feb 20, 2020

Closing issue. Fixed in above references.

@sQVe sQVe closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants