fix: improve regex path matching #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #87.
Codecov Report
@@ Coverage Diff @@
## develop #90 +/- ##
========================================
Coverage 90.99% 90.99%
========================================
Files 18 18
Lines 422 422
Branches 106 105 -1
========================================
Hits 384 384
Misses 38 38
Continue to review full report at Codecov.
|
waynevanson
approved these changes
Mar 2, 2020
| } | ||
| importPaths.push(matches[1] ?? matches[2]); | ||
| importPaths.push(matches[1]); |
AnatoleLucet
approved these changes
Mar 2, 2020
benawad
approved these changes
Mar 2, 2020
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://regex101.com/r/SkaHYp/1/ for further details.
This closes #87.