Skip to content
This repository has been archived by the owner on Sep 13, 2021. It is now read-only.

Fix compilation errore due to conflict of library google-play-service… #6

Closed
wants to merge 4 commits into from

Conversation

nonno
Copy link
Contributor

@nonno nonno commented Oct 3, 2015

I tried to use this module in a project where I used ti.map too and it never worked on Android, because including library google-play-services.jar I had errors of class already defined.
So I removed the jar replacing it with a "base" version (I got it from ti.admob module) and a "analytics" version I created using ProGuard.
Now it works, either alone and in conjunction with ti.map and ti.admob, and module is also 2MB smaller.

…s.jar with libraries in modules ti.map and ti.admob.
@m1ga
Copy link

m1ga commented Oct 4, 2015

👍

@nonno
Copy link
Contributor Author

nonno commented Oct 4, 2015

Error I obtained before the fix was this one:
[ERROR] : UNEXPECTED TOP-LEVEL EXCEPTION:
[ERROR] : java.lang.IllegalArgumentException: already added: Lcom/google/android/gms/maps/LocationSource;

@williamrijksen
Copy link

@benbahrenburg Created 1.0.2 dist for Android.

@ghost
Copy link

ghost commented Oct 26, 2015

What version of play services is this using? I can't even find the integer play services version in the timodule.xml

@nonno
Copy link
Contributor Author

nonno commented Oct 27, 2015

@Mlimb I have no idea, I simply got the one used by @benbahrenburg and I splitted it, adding the "analytics part" to the "base part" I previously got from ti.admob (for avoiding duplications). I wasn't completely sure about compatibility but it worked.

…, the previous one was the 3.10 (November 2014).

Create dist 1.0.2 for ios.
@benbahrenburg
Copy link
Owner

Thanks @nonno I've manually merged these changes in with others I have.

@Mlimb I think your comment about version is going to be important. I've asked AppC to provide the full version of the Google Play jar they are using. This will make sure everything is running on the same version.

@nonno
Copy link
Contributor Author

nonno commented Nov 26, 2015

It's good that you haven't abandoned your project, but it would have been better to merge my commits and after to change eventual mistakes. It's not pleasant to work many hours for solving problems on disappeared people's projects and to see your contributions vanishing.

@benbahrenburg
Copy link
Owner

@nonno I appreciate your help in going through the updates. Just as you stated I wanted to avoid the hours it would take to go through the merge process and the associated errors. That is why I did the merge manually. I'm happy to add you as contributor to the read me file. No ill will was meant, just trying to save time.

@nonno
Copy link
Contributor Author

nonno commented Nov 27, 2015

@benbahrenburg I don't care to be in readme file, I only like to see something in "Repositories contributed to" section of my profile, because unluckily I don't have often opportunities for working on github's projects. By the way, happy to see that this project is not abandoned and thanks for your work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants