Urls starting with / handled as absolute urls from the root #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome! Congrats on your first pull request to Jekyll Relative Links. If you haven't already, please be sure to check out the contributing guidelines. |
|
Also found an old issue, #47 |
benbalter
reviewed
Jun 29, 2020
| relative_path.sub!(%r!\A/!, "") | ||
| absolute_path = File.expand_path(relative_path, url_base) | ||
| base = is_absolute ? "" : url_base | ||
| absolute_path = File.expand_path(relative_path, base) |
There was a problem hiding this comment.
Would it make sense to put this in path_from_root rather than passing it around?
benbalter
approved these changes
Jun 29, 2020
|
Congrats on getting your first pull request to Jekyll Relative Links merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests makes absolute urls behave the same way as on github. A url that starts with a / should be interpreted as an absolute url, starting from the root.
Example:
if we have the file foo/bar.md, containing the link
[my absolute link](/foo/bar.md), the generated html should point to /foo/bar/View rendered spec/fixtures/site/page.md
View rendered spec/fixtures/site/subdir/page.md