Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially broken with jquery 1.6 #29

Closed
AlexandreBernard opened this issue May 11, 2011 · 12 comments
Closed

partially broken with jquery 1.6 #29

AlexandreBernard opened this issue May 11, 2011 · 12 comments

Comments

@AlexandreBernard
Copy link

I tried the plugin (which is awesome and should be in jQuery core honestly) with 1.6 and it didn't work completely.

I just have a simple animation where i change the left value of a div inside another one. Works fine with jQuery 1.5.2.

With 1.6, the first animation is correctly done but the other ones on the same element won't work then. the div remains blocked at the same position. haven't tested on others yet.

I'm trying to find the fix but I don't know jQuery core so well

@benbarnett
Copy link
Owner

Thanks for this, I hadn't got around to trying it in 1.6 so I'll get on this and have a look through the core. I'm fairly familiar with the animation methods in it now, so hopefully can spot what's changed and get a fix out.

Just hope its doesn't break backwards compatibility for the 1.5.x people.

Thanks again for letting me know, I'll get on it.

@licx
Copy link

licx commented May 17, 2011

I'm experiencing problems with jQuery 1.6.1 as well. In my case I'm using the fadeTo() function. I'm trying to fade in an iframe from opacity 0 to opacity 1. The iframe doesn't fade in and stays with opacity 0. Everything works fine with jQuery 1.5.2.

Btw your plugin is awesome!

@codecomputerlove
Copy link

Hi there, yeah we are experiencing issues on 1.6.1 with our PhotoSwipe project (https://github.com/codecomputerlove/PhotoSwipe). Any help on getting this great plugin working on the latest jQuery would be fantastic!

Thanks, great work BTW!

@ggilder
Copy link

ggilder commented May 26, 2011

Any update on this? This plugin looks like it would be perfect for a project I'm working on, but I need 1.6 compatibility...

@licx
Copy link

licx commented May 26, 2011

I also need this plugin to work with jQuery 1.6.

@benbarnett any way I can help fixing this?

@ggilder
Copy link

ggilder commented May 26, 2011

I could also try to help out... do we have any reductions of the issues that we can use to figure out where to start?

@benbarnett
Copy link
Owner

Sorry guys been so held up recently on client work I still haven't had a chance to look through this properly. I'm going to try and run some tests this morning to find out why 1.6 isn't working.

New release on its way as soon as!

@benbarnett
Copy link
Owner

Just released a new version, it was to do with the sync'd animations. Hopefully this will fix most of the issues!

@codecomputerlove
Copy link

Brilliant Ben, thanks so much, looks like it's working a treat. Excellent!

@benbarnett
Copy link
Owner

Great thanks! I'll close the issue.

@ggilder
Copy link

ggilder commented May 31, 2011

Thanks so much Ben! Seems to be working great.

@licx
Copy link

licx commented Jun 1, 2011

Thank you Ben :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants