-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.animate() callback passes wrong object #35
Comments
It seems to fail in Chrome, but I think works as expected in IE 9. Which means it's probably related to the webkit-specific functions. |
Good find! I'll have a look now, should be relatively easy to fix unless it has other knock on effects. |
benbarnett
added a commit
that referenced
this issue
Jun 15, 2011
benbarnett
added a commit
that referenced
this issue
Jun 15, 2011
Just added a release, do you want to see if it works? |
ggilder
pushed a commit
to ggilder/jQuery-Animate-Enhanced
that referenced
this issue
Sep 26, 2011
…t for callback
ggilder
pushed a commit
to ggilder/jQuery-Animate-Enhanced
that referenced
this issue
Sep 26, 2011
…t for callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
BRILLIANT work with this plugin. Love it!
But think I found a bug... This code works with the default jQuery animate() but fails with your version.
In standard jQuery,
this
in the callback refers to the actual DOM object, whereas in your version it's the jQuery object, with the DOM object as array index [0].It's relatively simple to work-around, but took me ages to figure out the cause of the problem. How hard is it to fix this?
Simon.
The text was updated successfully, but these errors were encountered: