Fixed issue with fadeOut() / "hide" shortcut #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, thank you! I'm really busy on client work this week so i'm hoping to pull this at the weekend. I'll let you know on here. Thanks again. |
|
No problem, another thing I noticed but haven't fixed is that the fadeIn() shortcut will mess up styles for any elements that aren't "display: block" to start with. Before fading in you are checking to see if the element is hidden and then setting "display: block" and "opacity: 0" to prepare for the fade in. Should probably be caching whatever the display property of that element originally was instead of always assuming "block". Pretty minor thing, maybe I'll fix it as well if I have some time this weekend. |
jefferyto
pushed a commit
to jefferyto/jquery-animate-enhanced
that referenced
this pull request
Apr 4, 2022
… "hide" shortcut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for a great project Ben!
In the _interpretValue() function you were translating an opacity value of "show" to 1 but I needed to add another check for changing the value of "hide" to 0 to get jQuery's fadeOut() to work properly. Also in the cssCallback function after the animation completes I added a check to change the css of the elements to display: none if the "hide" shortcut was used.