Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues with Pale Moon #9

Closed
rdegraaff opened this issue Jan 15, 2015 · 13 comments
Closed

Compatibility issues with Pale Moon #9

rdegraaff opened this issue Jan 15, 2015 · 13 comments

Comments

@rdegraaff
Copy link

I'm using Pale Moon x64, which is based on Firefox. Since their latest version (25.2.0) images called from img tags are not rendered, when Image Toolbar 0.6.14 is installed. The add-on worked fine with Pale Moon 25.1.0. Newer versions of the add-on are not installable (incompatible "Firefox" version).

Pale Moon's main dev pointed me to these changes as the possible cause / solution. Is there anything you could do to fix the incompatibility? I've been happily using your add-on for some years.

@z235
Copy link

z235 commented Jan 16, 2015

Another Pale Moon user here.

Hello Ben, adding support for PM would be great indeed. You seem like a cool guy, so I hope you are willing to make this compatible to our little browser project... 🍻

@gdighton
Copy link

Also a Pale Moon user, and experienced the same problem (glad to see I'm not the only one!)

@emicom
Copy link

emicom commented Jan 20, 2015

The same with me. I've use Image Toolbar for years now and (honestly) is my favorite add-on. But with PM 25.2 is not possible to to install IT 0.6.16 or 0.6.15.
Pls Ben, can you help and make IT for PM users work? :)

@emicom
Copy link

emicom commented Jan 20, 2015

Yeah, I think I found a solution. In the file {A4732521-77D9-447E-A557-B279AC923F06}.xpi (it is IT xpi located in _\Application Data\Moonchild Productions\Pale Moon\Profiles_) chrome\imagetoolbar\content\imagetoolbar.xml on entry " binding id" (I am talking for ver. 0.6.15) must be - it happen twice. Then (for compatible issue of PM) in the xpi install.rdf the must change the old entry to:
em:minVersion25.0/em:minVersion
em:maxVersion27.0.*/em:maxVersion
Hope it temporarily helps.
Ben, can you please make IT compatible with Pale Moon 25+?:)

@Trapperman
Copy link

^^^ Ditto on everything above x100

I've become so dependent on Image Toolbar that I feel lost without it now. PLEASE Ben, make it compatible with Pale Moon v25.2++

@masoko182
Copy link

I'm another Pale Moon user, please update your awesome extension so it can be compatible. Thanks in advance!

@sobcz
Copy link

sobcz commented Mar 14, 2015

You can get my fixed version from http://1drv.ms/1GFlyFu, file image_toolbar-0.6.16-pmfix.xpi. I sent pull request some time ago, but it seems that author is busy. Then I kind of forgot about it (it worked here, so... ;).

Changes can be seen in pull request #10, plus there's changed name to "Image Toolbar (unofficial Pale Moon hotfix)". But don't trust me, check it yourself (hint: xpi is renamed zip).

@masoko182
Copy link

Thanx! It works like a charm

2015-03-14 19:54 GMT-03:00 Sob notifications@github.com:

You can get my fixed version from http://1drv.ms/1GFlyFu, file
image_toolbar-0.6.16-pmfix.xpi. I sent pull request some time ago, but it
seems that author is busy. Then I kind of forgot about it (it worked here,
so... ;).

Changes can be seen in pull request #10
#10, plus there's changed
name to "Image Toolbar (unofficial Pale Moon hotfix)". But don't trust me,
check it yourself (hint: xpi is renamed zip).


Reply to this email directly or view it on GitHub
#9 (comment)
.

@benbasson
Copy link
Owner

Hi everyone. Sorry, I have no plans to add support for Pale Moon (as I do not use it and do not want to download loads of Firefox / Mozilla forks to test my add-ons with), but I will keep maintaining the addon-on for use with Firefox.

If someone wants to maintain a Pale Moon fork of Image Toolbar on GitHub I'm more than happy to work with them on that and am happy to share new code / features - I just don't want the extra testing / compatibility burden.

@mattatobin
Copy link

Greetings. What are your terms for the brand of "Image Toolbar" or should the Pale Moon Add-ons Team rebrand it.

@benbasson
Copy link
Owner

I'd be happy for it to be called "Image Toolbar for Pale Moon" or similar. Please credit me as the original author + retain licence headers while adding anyone necessary as additional authors.

@mattatobin
Copy link

Of course we will follow the terms of the MPL.

@mattatobin
Copy link

We have successfully forked the code under the name Image Toolbox. All Pale Moon users should switch to this version located on our Add-ons site.

Mr. Basson thank you for your cooperation.

Feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants