Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 77e1a17 breaks multiplex.t #26

Closed
elindsey opened this issue Dec 26, 2013 · 4 comments
Closed

Commit 77e1a17 breaks multiplex.t #26

elindsey opened this issue Dec 26, 2013 · 4 comments

Comments

@elindsey
Copy link
Contributor

Looks like the repeat syntax used for aggregator snippets isn't compatible with bundling:

[eli@flatline:~/Code/RecordStream]$ perlbrew exec perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t
perl-5.8.9
==========
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. 1/? Cannot repeat while bundling: "mr-agg=s{4}"
Cannot repeat while bundling: "ii-agg=s{4}"
Can't call method "main_usage" on an undefined value at /Users/eli/Code/RecordStream/lib/App/RecordStream/Operation/collate.pm line 164,  line 1.
# Looks like your test exited with 2 just after 24.
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. Dubious, test returned 2 (wstat 512, 0x200)
All 24 subtests passed 

Test Summary Report
-------------------
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t (Wstat: 512 Tests: 24 Failed: 0)
  Non-zero exit status: 2
Files=1, Tests=24,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.10 cusr  0.01 csys =  0.15 CPU)
Result: FAIL
Failed 1/1 test programs. 0/24 subtests failed.
Command terminated with non-zero status.
Command [perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t] terminated with exit code 2 ($? = 512) under the following perl environment:
Current perl:
  Name: perl-5.8.9
  Path: /Users/eli/Code/perlbrew/perls/perl-5.8.9/bin/perl
  Config: -de -Dprefix=/Users/eli/Code/perlbrew/perls/perl-5.8.9 -Aeval:scriptdir=/Users/eli/Code/perlbrew/perls/perl-5.8.9/bin
  Compiled at: Apr 22 2013 23:20:14

perlbrew:
  version: 0.67
  ENV:
    PERLBREW_ROOT: /Users/eli/Code/perlbrew
    PERLBREW_HOME: /Users/eli/.perlbrew
    PERLBREW_PATH: /Users/eli/Code/perlbrew/bin:/Users/eli/Code/perlbrew/perls/perl-5.8.9/bin
    PERLBREW_MANPATH: /Users/eli/Code/perlbrew/perls/perl-5.8.9/man


perl-5.16.3
==========
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. 1/? Cannot repeat while bundling: "mr-agg=s{4}"
Cannot repeat while bundling: "ii-agg=s{4}"
Can't call method "main_usage" on an undefined value at /Users/eli/Code/RecordStream/lib/App/RecordStream/Operation/collate.pm line 164,  line 1.
# Looks like your test exited with 2 just after 24.
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. Dubious, test returned 2 (wstat 512, 0x200)
All 24 subtests passed 

Test Summary Report
-------------------
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t (Wstat: 512 Tests: 24 Failed: 0)
  Non-zero exit status: 2
Files=1, Tests=24,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.13 cusr  0.02 csys =  0.19 CPU)
Result: FAIL
Failed 1/1 test programs. 0/24 subtests failed.
Command terminated with non-zero status.
Command [perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t] terminated with exit code 2 ($? = 512) under the following perl environment:
Current perl:
  Name: perl-5.16.3
  Path: /Users/eli/Code/perlbrew/perls/perl-5.16.3/bin/perl
  Config: -de -Dprefix=/Users/eli/Code/perlbrew/perls/perl-5.16.3 -Aeval:scriptdir=/Users/eli/Code/perlbrew/perls/perl-5.16.3/bin
  Compiled at: Dec 16 2013 18:19:46

perlbrew:
  version: 0.67
  ENV:
    PERLBREW_ROOT: /Users/eli/Code/perlbrew
    PERLBREW_HOME: /Users/eli/.perlbrew
    PERLBREW_PATH: /Users/eli/Code/perlbrew/bin:/Users/eli/Code/perlbrew/perls/perl-5.16.3/bin
    PERLBREW_MANPATH: /Users/eli/Code/perlbrew/perls/perl-5.16.3/man


perl-5.18.1
==========
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. 1/? Cannot repeat while bundling: "ii-agg=s{4}"
Cannot repeat while bundling: "mr-agg=s{4}"
Can't call method "main_usage" on an undefined value at /Users/eli/Code/RecordStream/lib/App/RecordStream/Operation/collate.pm line 164,  line 1.
# Looks like your test exited with 2 just after 24.
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. Dubious, test returned 2 (wstat 512, 0x200)
All 24 subtests passed 

Test Summary Report
-------------------
/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t (Wstat: 512 Tests: 24 Failed: 0)
  Non-zero exit status: 2
Files=1, Tests=24,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.15 cusr  0.02 csys =  0.21 CPU)
Result: FAIL
Failed 1/1 test programs. 0/24 subtests failed.
Command terminated with non-zero status.
Command [perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t] terminated with exit code 2 ($? = 512) under the following perl environment:
Current perl:
  Name: perl-5.18.1
  Path: /Users/eli/Code/perlbrew/perls/perl-5.18.1/bin/perl
  Config: -de -Dprefix=/Users/eli/Code/perlbrew/perls/perl-5.18.1 -Aeval:scriptdir=/Users/eli/Code/perlbrew/perls/perl-5.18.1/bin
  Compiled at: Oct  6 2013 18:29:51

perlbrew:
  version: 0.67
  ENV:
    PERLBREW_ROOT: /Users/eli/Code/perlbrew
    PERLBREW_HOME: /Users/eli/.perlbrew
    PERLBREW_PATH: /Users/eli/Code/perlbrew/bin:/Users/eli/Code/perlbrew/perls/perl-5.18.1/bin
    PERLBREW_MANPATH: /Users/eli/Code/perlbrew/perls/perl-5.18.1/man
@tsibley
Copy link
Collaborator

tsibley commented Dec 26, 2013

Oh bother. This is why it stinks to have a failing test suite under 5.16. I should have tested on an older Perl. I can look into this in the next few days.

On Dec 26, 2013, at 1:45, Eli Lindsey notifications@github.com wrote:

Looks like the repeat syntax used for aggregator snippets isn't compatible with bundling:

[eli@flatline:~/Code/RecordStream]$ perlbrew exec perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t

perl-5.8.9

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. 1/? Cannot repeat while bundling: "mr-agg=s{4}"
Cannot repeat while bundling: "ii-agg=s{4}"
Can't call method "main_usage" on an undefined value at /Users/eli/Code/RecordStream/lib/App/RecordStream/Operation/collate.pm line 164, line 1.

Looks like your test exited with 2 just after 24.

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. Dubious, test returned 2 (wstat 512, 0x200)
All 24 subtests passed

Test Summary Report

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t (Wstat: 512 Tests: 24 Failed: 0)
Non-zero exit status: 2
Files=1, Tests=24, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.10 cusr 0.01 csys = 0.15 CPU)
Result: FAIL
Failed 1/1 test programs. 0/24 subtests failed.
Command terminated with non-zero status.
Command [perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t] terminated with exit code 2 ($? = 512) under the following perl environment:
Current perl:
Name: perl-5.8.9
Path: /Users/eli/Code/perlbrew/perls/perl-5.8.9/bin/perl
Config: -de -Dprefix=/Users/eli/Code/perlbrew/perls/perl-5.8.9 -Aeval:scriptdir=/Users/eli/Code/perlbrew/perls/perl-5.8.9/bin
Compiled at: Apr 22 2013 23:20:14

perlbrew:
version: 0.67
ENV:
PERLBREW_ROOT: /Users/eli/Code/perlbrew
PERLBREW_HOME: /Users/eli/.perlbrew
PERLBREW_PATH: /Users/eli/Code/perlbrew/bin:/Users/eli/Code/perlbrew/perls/perl-5.8.9/bin
PERLBREW_MANPATH: /Users/eli/Code/perlbrew/perls/perl-5.8.9/man

perl-5.16.3

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. 1/? Cannot repeat while bundling: "mr-agg=s{4}"
Cannot repeat while bundling: "ii-agg=s{4}"
Can't call method "main_usage" on an undefined value at /Users/eli/Code/RecordStream/lib/App/RecordStream/Operation/collate.pm line 164, line 1.

Looks like your test exited with 2 just after 24.

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. Dubious, test returned 2 (wstat 512, 0x200)
All 24 subtests passed

Test Summary Report

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t (Wstat: 512 Tests: 24 Failed: 0)
Non-zero exit status: 2
Files=1, Tests=24, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.13 cusr 0.02 csys = 0.19 CPU)
Result: FAIL
Failed 1/1 test programs. 0/24 subtests failed.
Command terminated with non-zero status.
Command [perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t] terminated with exit code 2 ($? = 512) under the following perl environment:
Current perl:
Name: perl-5.16.3
Path: /Users/eli/Code/perlbrew/perls/perl-5.16.3/bin/perl
Config: -de -Dprefix=/Users/eli/Code/perlbrew/perls/perl-5.16.3 -Aeval:scriptdir=/Users/eli/Code/perlbrew/perls/perl-5.16.3/bin
Compiled at: Dec 16 2013 18:19:46

perlbrew:
version: 0.67
ENV:
PERLBREW_ROOT: /Users/eli/Code/perlbrew
PERLBREW_HOME: /Users/eli/.perlbrew
PERLBREW_PATH: /Users/eli/Code/perlbrew/bin:/Users/eli/Code/perlbrew/perls/perl-5.16.3/bin
PERLBREW_MANPATH: /Users/eli/Code/perlbrew/perls/perl-5.16.3/man

perl-5.18.1

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. 1/? Cannot repeat while bundling: "ii-agg=s{4}"
Cannot repeat while bundling: "mr-agg=s{4}"
Can't call method "main_usage" on an undefined value at /Users/eli/Code/RecordStream/lib/App/RecordStream/Operation/collate.pm line 164, line 1.

Looks like your test exited with 2 just after 24.

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t .. Dubious, test returned 2 (wstat 512, 0x200)
All 24 subtests passed

Test Summary Report

/Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t (Wstat: 512 Tests: 24 Failed: 0)
Non-zero exit status: 2
Files=1, Tests=24, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.15 cusr 0.02 csys = 0.21 CPU)
Result: FAIL
Failed 1/1 test programs. 0/24 subtests failed.
Command terminated with non-zero status.
Command [perl -I./lib ./test.pl 0 /Users/eli/Code/RecordStream/tests/RecordStream/Operation/multiplex.t] terminated with exit code 2 ($? = 512) under the following perl environment:
Current perl:
Name: perl-5.18.1
Path: /Users/eli/Code/perlbrew/perls/perl-5.18.1/bin/perl
Config: -de -Dprefix=/Users/eli/Code/perlbrew/perls/perl-5.18.1 -Aeval:scriptdir=/Users/eli/Code/perlbrew/perls/perl-5.18.1/bin
Compiled at: Oct 6 2013 18:29:51

perlbrew:
version: 0.67
ENV:
PERLBREW_ROOT: /Users/eli/Code/perlbrew
PERLBREW_HOME: /Users/eli/.perlbrew
PERLBREW_PATH: /Users/eli/Code/perlbrew/bin:/Users/eli/Code/perlbrew/perls/perl-5.18.1/bin
PERLBREW_MANPATH: /Users/eli/Code/perlbrew/perls/perl-5.18.1/man

Reply to this email directly or view it on GitHub.

@benbernard
Copy link
Owner

I had some time, so I fixed this today. FYI, tests work for me on mac in 5.16...

The issue was global scope of config changes, we have a couple scripts (multiplex and chain) that can create & invoke operations themselves, so global settings on Getopt::Long::Configure were conflicting.

@benbernard
Copy link
Owner

FYI, fixed in SHA ce4ecff

@tsibley
Copy link
Collaborator

tsibley commented Dec 26, 2013

Sorry, I meant 5.18. See
https://rt.cpan.org/Public/Bug/Display.html?id=91452

Thanks for the fix!

On 12/26/2013 12:28 PM, Ben Bernard wrote:

I had some time, so I fixed this today. FYI, tests work for me on mac
in 5.16...

The issue was global scope of config changes, we have a couple scripts
(multiplex and chain) that can create & invoke operations themselves,
so global settings on Getopt::Long::Configure were conflicting.


Reply to this email directly or view it on GitHub
#26 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants