Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recs-totable delimiter #80

Closed
bokutin opened this issue Jun 5, 2018 · 2 comments
Closed

recs-totable delimiter #80

bokutin opened this issue Jun 5, 2018 · 2 comments

Comments

@bokutin
Copy link
Contributor

bokutin commented Jun 5, 2018

recs-fromps | recs-totable --spreadsheet --delimiter ','

Unknown option: delimiter

Help and code do not match in option handling.

RecordStream/lib/App/RecordStream/Operation/totable.pm

Line 26 in fcfd05a

"delim|d=s" => \$delimiter,

RecordStream/lib/App/RecordStream/Operation/totable.pm

Line 228 in fcfd05a

['delimiter <string>', 'Only useful with --spreadsheet, delimit with <string> rather than the default of a tab'],

tsibley added a commit that referenced this issue Jun 6, 2018
@tsibley
totable: Correct --delim option name in help
a31da8a 
Resolves GH #80.  Thanks Tomohiro Hosaka!
@tsibley
Copy link
Collaborator

tsibley commented Jun 6, 2018

Thanks for the report! Fixed and released as 4.0.25.

@tsibley tsibley closed this as completed Jun 6, 2018
@tsibley
Copy link
Collaborator

tsibley commented Jun 6, 2018

To clarify, I updated the --help documentation to say --delim since that's the most commonly used variant in other recs commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsibley @bokutin