Perl 5.21.1 compat #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a hash as a reference was deprecated before Perl 5.8 and is a compilation error starting in 5.21.1. This caused most of the test suite to fail under 5.21.1.
…alue This removes the variable's value for any existing references to it outside the symbol table. The symbol table is only used for new compilations (i.e. string eval during runtime). Note that ->clear_vars() appears unused in the core of recs, though it may be used by outside callers.
This deprecation warning was added in a 5.17 development release, but
removed before 5.18 due to unforeseen syntax issues when the regex
delimiters were curly braces (m{...}). Perl 5.21.1 re-introduces this
deprecation warning now that the syntax issues are resolved. Presumably
the deprecation warning will remain for the next stable release, 5.22,
this time.
Escaping the braces should cause no problems on earlier perls.
|
I should note that all tests pass for me under 5.21.1 and 5.18.2 with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation errors and silences deprecation warnings introduced in Perl 5.21.1.
A small bug-fix is also included in related code.