Optional test deps #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing This is a cleaner spot to do optional dep checking in tests than copy and pasting specific operation deps and the code to check for them into each test script.
Otherwise failure diagnostics come from within the test libraries and make finding the failing test in the testfile itself harder than it should be.
Since the move to a pure-Perl set of core required deps (with specific-operational deps moved into features), fromxml, fromatomfeed, fromdb, and todb are no longer guaranteed dep satisfaction. (But if they try sometimes, well they might just find, they get what they need.)
…d newlines + allow_loose_quotes
The XS implementation works fine, so only skip the failing tests if we
we're not using Text::CSV_XS. I reported this bug as [rt.cpan.org #99589]:
https://rt.cpan.org/Ticket/Display.html?id=99589
Most of the diff for this change is whitespace, so best viewed with
whitespace ignored.
Author tests are run under `milla test`.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #48.