[ContributorsFromGit] -> [Git::Contributors] #73
Conversation
This plugin has unresolved issues on MSWin32 and with handling unicode names, so I forked it last year.
|
Thanks for the heads up @ether. None of the releasers of recs are using Windows, so that shouldn't be a big deal, I think. What are the Unicode fixes? I'd like to understand what's changed before I switch it up. It'd be nice if Git::Contributors had a "differences from ContributorsFromGit" section in the doc. :-) |
|
The differences from the other plugin would be a rather large list. Aside from the options to allow different sorting orders and whether to include authors and/or releasers, bug fixes include proper decoding of the author's and releaser's name (so on ContributorsFromGit, if your name is Olivier Mengué, you're just SOL), and not messing around with the user's podweaver configuration. Also there is a workaround for unicode issues on older JSON::PP on older perls (where any JSON::PP before the latest release would cause an install to blow up if META.json contained any unicode data, anywhere, meaning a distribution with a non-ascii contributor name would be uninstallable on perl 5.6). |
ETHER makes the case for this on GH #73. She's kinda the queen of dzil, so I trust her judgment. :)
|
Closed with 2772c47. I actually forgot that this was a PR and not an issue, so I made the change myself in a new commit. |
|
no worries, cheers! |
This plugin has unresolved issues on MSWin32 and with handling unicode names, so I forked it last year.