parsedate: Parse and reformat dates and times #74
Conversation
|
Yay! Travis caught a problem with older Perls I didn't realize would be an issue. I'll fix it up tomorrow. |
|
This branch is now good to go. @benbernard, would you take a look? |
|
|
||
| my $options = { | ||
| 'key|k=s' => sub { $this->{'KEYS'}->add_groups($_[1]) }, | ||
| 'format|f=s' => \($this->{'FORMAT'}), |
There was a problem hiding this comment.
I hadn't seen this ($hash->{key}) format before, cool!
|
Looks great! I had a few comments, but feel free to merge as-is |
|
Thanks for the notes! I'll make the changes you recommended and merge away. |
|
In adding some tests, I just found a bug (timezones, naturally), so I'm going to fix that and repush at some point (probably not today). |
|
awesome, glad you found it! On Sun, Feb 28, 2016 at 11:53 AM Thomas Sibley notifications@github.com
|
Naming tests is often very helpful in debugging to ensure you're looking at the right thing and to more quickly get a sense of what's broken.
Basically a front-end to Time::ParseDate, which offers more control than Date::Manip::DM5's ParseDate(). The fatpack recs, already 7.4MB, is increased only 28KB by Time::ParseDate, so there's no huge loss to avoid it. POSIX, luckily, is part of core.
Basically a front-end to Time::ParseDate, which offers more control than Date::Manip::DM5's
ParseDate(). The fatpack recs, already 7.4MB, is increased only 28KB by Time::ParseDate, so there's no huge loss to avoid it. POSIX, luckily, is part of core.