Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette of covariance adjustment with auxiliary data in a pair-matched study #179

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jwasserman2
Copy link
Collaborator

No description provided.

@jwasserman2 jwasserman2 linked an issue May 31, 2024 that may be closed by this pull request
4 tasks
@jwasserman2
Copy link
Collaborator Author

jwasserman2 commented May 31, 2024

@josherrickson thoughts on having added paireddata for this vignette as a dataset for the package?
@benthestatistician thoughts on what the vignette covers?

**Additionally, the site build keeps failing because we aren't storing the data necessary to run the vignette in the package. Should this go in /inst?

@benthestatistician
Copy link
Contributor

Re vignette coverage, I much like what I'm seeing. I have some ideas about how the vignette could state its purposes to highlight what's special about propertee, but perhaps it would be more efficient for me to add and edit text myself sometime in the coming weeks than to start wordsmithing now. So for now I'll keep those ideas to myself.

I figured this vignette would offer a natural opportunity to show off the weights=ate(des)*measure_of_cluster_size construction, so was surprised not to see it here. I'd think we should; without measures of cluster size, we estimate the effect of the treatment on school level averages. But if we bring in cluster size as above, then we get to estimate student level effects (despite our being restricted to aggregated data).

I'll let Josh E chime in about the paireddata addition, but I'll comment that:

  • I like having it but might suggest a name like "michigan_school_pairs"
  • Would be good to say that the schools we're looking at here are the closest matches we found to the schools that had participated in an RCT in a neighboring county
  • it would be worth clarifying that there was no known intervention was happening at the school pairs and triples, so the expected effects in our example are 0 (although the actual RCT it's modeled on did seem to have some effect).

@josherrickson
Copy link
Collaborator

No objection to adding more data, as long as it's small enough to not trigger CRAN's size warning. I believe it warns if any directory is greater than 1Mb, based upon this note on rlemon's checks:

 Result: NOTE
    installed size is  5.0Mb
    sub-directories of 1Mb or more:
      lemon   2.9Mb
      libs    1.9Mb

It wouldn't be a total stopper, but avoiding any notes should ease CRAN submissions.

@jwasserman2
Copy link
Collaborator Author

I like the name "michigan_school_pairs"; I'll re-name it. No issues about size--it's only half a kilabyte. In the vignette, I'll clarify we expect to find no effect given there was no intervention to our knowledge. I agree that you should make comments directly to the vignette, Ben.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcovDA's applicable to paired assignment, w/ illustrative vignette
3 participants