-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vignette of covariance adjustment with auxiliary data in a pair-matched study #179
base: main
Are you sure you want to change the base?
Conversation
@josherrickson thoughts on having added **Additionally, the site build keeps failing because we aren't storing the data necessary to run the vignette in the package. Should this go in |
Re vignette coverage, I much like what I'm seeing. I have some ideas about how the vignette could state its purposes to highlight what's special about propertee, but perhaps it would be more efficient for me to add and edit text myself sometime in the coming weeks than to start wordsmithing now. So for now I'll keep those ideas to myself. I figured this vignette would offer a natural opportunity to show off the I'll let Josh E chime in about the paireddata addition, but I'll comment that:
|
No objection to adding more data, as long as it's small enough to not trigger CRAN's size warning. I believe it warns if any directory is greater than 1Mb, based upon this note on rlemon's checks:
It wouldn't be a total stopper, but avoiding any notes should ease CRAN submissions. |
I like the name "michigan_school_pairs"; I'll re-name it. No issues about size--it's only half a kilabyte. In the vignette, I'll clarify we expect to find no effect given there was no intervention to our knowledge. I agree that you should make comments directly to the vignette, Ben. |
No description provided.