Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(perf) Replace bytes.Buffer with strings.Builder #32

Closed
trakhimenok opened this issue Feb 27, 2018 · 2 comments
Closed

(perf) Replace bytes.Buffer with strings.Builder #32

trakhimenok opened this issue Feb 27, 2018 · 2 comments

Comments

@trakhimenok
Copy link

Improve performance by using strings.Builder instead of bytes.Buffer where possible.

https://golang.org/doc/go1.10#strings

https://golang.org/pkg/strings/#Builder
@benbjohnson
Copy link
Owner

@astec Are you having performance issues? I find the codegen pretty fast and I'm not sure breaking 1.9 compatibility is worth it.

@trakhimenok
Copy link
Author

No, I don't have performance issues and probably you are right so am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benbjohnson @trakhimenok