Add ListBuilder #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 814 887 +73
=====================================
+ Hits 814 887 +73
Continue to review full report at Codecov.
|
benbjohnson
force-pushed
the
list-builder
branch
from
6110052
to
ec787c6
Compare
This commit adds a builder for more efficiently creating `List` objects. It works by mutating the list in-place until the current list is requested. After that request, the next mutation will occur on a copy but then continue to mutate in place. This allows lists to be returned and used while continuing to use the builder.
benbjohnson
force-pushed
the
list-builder
branch
from
ec787c6
to
08218d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a builder for more efficiently creating
Listobjects. It works by mutating the list in-place until the current list is requested. After that request, the next mutation will occur on a copy but then continue to mutate in place. This allows lists to be returned and used while continuing to use the builder.Closes #2