This repository has been archived by the owner on Dec 15, 2019. It is now read-only.
Implements case where a map in ReadMap contains arrays. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,7 @@ type Scanner interface { | |||
| ReadFloat64(target *float64) error | |||
| ReadBool(target *bool) error | |||
| ReadMap(target *map[string]interface{}) error | |||
| ReadSlice(target *[]interface{}) error | |||
There was a problem hiding this comment.
@aybabtme Can you change the name to ReadArray()? The interface is meant to describe the actions from the JSON point-of-view so the terminology would be "array".
There was a problem hiding this comment.
'-.- called it like that at first
|
@aybabtme other than the naming nit, lgtm. |
|
Changed it to |
benbjohnson
added a commit
that referenced
this pull request
May 23, 2014
Implements case where a map in ReadMap contains arrays.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to read
map[string]interface{}in fatherhood and had the bad surprise of apanic: Not supported yet=). I saw theReadMapmethod on scanner was not able to read arrays, so I fixed that.I've added a
ReadSlicemethod on theScannerinterface, for consistency.Would this make megajson support arrays of any types?
r: @benbjohnson