Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Navigation #3

Closed
benbjohnson opened this issue Dec 6, 2013 · 5 comments
Closed

Keyboard Navigation #3

benbjohnson opened this issue Dec 6, 2013 · 5 comments
Labels
enhancement

Comments

@benbjohnson
Copy link
Owner

Add support for the right arrow key instead of requiring the user to constantly hit the "Continue" button.

/cc: @philips
@benbjohnson benbjohnson mentioned this issue Dec 6, 2013
Closed
@andybons
Copy link

andybons commented Dec 6, 2013

Would also be nice to be able to go back as well (both using the arrow keys and the UI)

@benbjohnson
Copy link
Owner Author

@andybons Going back is a little tricky. The visualization uses playback.js which separates larger sections into frames and snapshots the underlying model whenever moving forward to new frames. Going back a whole section (i.e. a frame) is easy because I have the snapshotted model but moving back within a frame is currently impossible because the model changes.

Maybe I'll adjust playback.js to use immutable objects so I can easily make continuous snapshots.

@benbjohnson
Copy link
Owner Author

benbjohnson/playback.js#1
benbjohnson/playback.js#2

@andybons
Copy link

andybons commented Dec 6, 2013

Gotcha. Sounds good!

@benbjohnson
Copy link
Owner Author

Fixed with 52377f1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benbjohnson @andybons