Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX 10.8.2 compiling issues #19

Closed
spamwax opened this issue Mar 9, 2013 · 8 comments
Closed

OSX 10.8.2 compiling issues #19

spamwax opened this issue Mar 9, 2013 · 8 comments

Comments

@spamwax
Copy link

spamwax commented Mar 9, 2013

I can compile from 'src' directory but not the top level
I'm getting errors, just trying to compile the master branch: error message

where do I get 'gdate' ?

@benblazak
Copy link
Owner

On Macports, the "gdate" program is part of the "coreutils" package - a package full of the GNU versions of stuff (since OS X by default comes with the BSD versions of stuff) - they prepend a "g" to the names of the programs by default in order not to mess up software that expects the BSD style commands.

@spamwax
Copy link
Author

spamwax commented Mar 10, 2013

thanks, that part is fixed but the error related to parsing the layout from .map file is still there.

The map file that's been created doesn't have any string to match regex in line 185:

re.search(r'.progmem.data.(_kb_layout\S*)', line).group(1)

Also shouldn't the dots in the above line be escaped similar to the calling function in line 215:

re.search(r'^\s*\.progmem\.data.*layout', line):

@benblazak
Copy link
Owner

we're using different versions of avr-gcc... :) lol - the top-level build process is really fragile, it was never meant to be widely used... :/ . it's one of the things i'm planning to replace (or just do away with...) in the (very slowly coming) rewrite.

mine is version 4.7.2 - you can see my .map file if you download the .zip of one of my recentish builds here

Edit:
also, you're probably right about the regex - but the current version works on my system, and i wasn't planning to touch the code much on this branch anymore. if you really want to though, you can send a pull request for any changes you make - and if it doesn't hurt the readibility of anything, and it still works on my system, i'll accept it. but please keep in mind that the script will be removed in the rewrite.

@spamwax
Copy link
Author

spamwax commented Mar 10, 2013

oh, 4.7.2 that's not fair given that the docs on the github sent me to an older version :)
I'm trying to avoid installing MacPorts since I'm already using Homebrew.

Why are you removing the script, I think it's cool and useful that every build generates its own layout in .svg.

@benblazak
Copy link
Owner

lol, sorry. looking around a bit, it's probably doubly unfair, since I didn't see any easy way to get 4.7.2 without macports, lol. grr... i can think of two other options:

  • edit the offending parts of the script out entirely: IIRC, none of the information read from the .map file is used for generating the .svg (or really for anything, that I know of - it was meant to be used by someone else's UI, earlier on in the project)
  • fix the regex so it works with the .map files generated by avr-gcc 4.6.2

The reason I think it needs to go is that it's kind of a brittle hack, which was fine for its purpose, but not so much fine to maintain... lol. But it's good to hear that somebody appreciates the .svg :) . I've been trying to think of different (better / less fragile) ways to do that once I get to rewriting that part. If I have time I'll keep the layout generation around.

@benblazak
Copy link
Owner

Just tested it - I think the following will fix the problem (at the cost of not having as much information in the ui-info file... which should be fine):

Go to the "build-scripts/gen-ui-info.py" file, and change the gen_derived and parse_mapfile functions to do nothing but return {}

def gen_derived(data):
    return {}

def parse_mapfile(map_file_path):
    return {}

@spamwax
Copy link
Author

spamwax commented Mar 12, 2013

thanks,it's working now.
yea, I tried compiling 4.7 from source but couldn't proceed past the GNU binutils step!

@benblazak
Copy link
Owner

lol. glad it works! :)

benblazak added a commit that referenced this issue Aug 1, 2014
some of the script's output won't be accurate anymore; but it's not data
that we actually need (and we haven't needed it for quite some time) so
that shouldn't bother anyone.  the generated keymap, assuming that still
works, should be fine though :)
jbcpollak added a commit to jbcpollak/ergodox-firmware that referenced this issue Aug 1, 2014
…anup

* commit '8fcfe6cb7e6df7ba0d6cc98b7ea72a7955c58d2e':
  changing gen-ui-info.py per issue benblazak#19
kisom pushed a commit to kisom/ergodox-firmware that referenced this issue Apr 27, 2016
some of the script's output won't be accurate anymore; but it's not data
that we actually need (and we haven't needed it for quite some time) so
that shouldn't bother anyone.  the generated keymap, assuming that still
works, should be fine though :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants