New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse & NKRO support #28

Closed
wants to merge 12 commits into
base: partial-rewrite
from

Conversation

Projects
None yet
3 participants
@dyuri

dyuri commented Jul 29, 2013

Hi Ben,

I was able to add NKRO and mouse support to your firmware based on hasu's firmware and the following thread: http://geekhack.org/index.php?topic=13162.msg259955#msg259955

Currently I use 24 byte long reports (it can include all the keycodes between 0 and 192; the 16 byte version doesn't include some keypad keys), and works fine (on linux at least, I have no access to OSX or Windows).

The code could be better organized, but lately you were quite busy as well, and I didn't want to wait until you do some great refactoring :)

Regards,
Gyuri

@benblazak

This comment has been minimized.

Show comment
Hide comment
@benblazak

benblazak Aug 4, 2013

Owner

Hey Guyri :)

Wow, thanks. I've decided not to merge, even though it was very nice of you to send a pull request. If you'd like me to try to articulate all the reasons why, I suppose I could, but for now maybe the comment I've added to the rev-2 readme will suffice. Sorry I didn't add that sooner... I've been meaning to for a while. Rev-2 wasn't really meant to be a public version yet, as it's not quite finished... I've just been recommending it to fellow programmers because (IMO) it's so much better organized than rev-1.

Also, I've linked to your branch from both the rev-1 and rev-2 readme's, in case other people would like to see your additions and/or merge them into their branches.

I do plan to implement the features eventually, albeit in a slightly different way. When I do, your code will likely be a good reference, and I'll give you credit in the comments :)

Thanks again!

Owner

benblazak commented Aug 4, 2013

Hey Guyri :)

Wow, thanks. I've decided not to merge, even though it was very nice of you to send a pull request. If you'd like me to try to articulate all the reasons why, I suppose I could, but for now maybe the comment I've added to the rev-2 readme will suffice. Sorry I didn't add that sooner... I've been meaning to for a while. Rev-2 wasn't really meant to be a public version yet, as it's not quite finished... I've just been recommending it to fellow programmers because (IMO) it's so much better organized than rev-1.

Also, I've linked to your branch from both the rev-1 and rev-2 readme's, in case other people would like to see your additions and/or merge them into their branches.

I do plan to implement the features eventually, albeit in a slightly different way. When I do, your code will likely be a good reference, and I'll give you credit in the comments :)

Thanks again!

@benblazak benblazak closed this Aug 4, 2013

@dyuri

This comment has been minimized.

Show comment
Hide comment
@dyuri

dyuri Aug 5, 2013

I'm looking forward to see rev-2 as the main branch, and thanks for your work!

I plan to keep my branch up-to-date as long as it's easy.

dyuri commented Aug 5, 2013

I'm looking forward to see rev-2 as the main branch, and thanks for your work!

I plan to keep my branch up-to-date as long as it's easy.

@mattboehm

This comment has been minimized.

Show comment
Hide comment
@mattboehm

mattboehm Oct 3, 2013

@dyuri I tried pulling your branch and building, but it did not seem to have nkro. My only change was to set KEYBOARD_LAYOUT = dvorak--kinesis-mod; NKRO_ENABLE was true. Any idea what might be happening? Do I have to use a PS/2 adapter?

mattboehm commented Oct 3, 2013

@dyuri I tried pulling your branch and building, but it did not seem to have nkro. My only change was to set KEYBOARD_LAYOUT = dvorak--kinesis-mod; NKRO_ENABLE was true. Any idea what might be happening? Do I have to use a PS/2 adapter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment