Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using TSDX to make the library tree-shakeable #146

Closed
alanrsoares opened this issue Jun 3, 2020 · 8 comments
Closed

Consider using TSDX to make the library tree-shakeable #146

alanrsoares opened this issue Jun 3, 2020 · 8 comments

Comments

@alanrsoares
Copy link

Should be not very intrusive to replace current build/bundling with https://github.com/jaredpalmer/tsdx.

I might have a go with it and open a PR.

@benbowes
Copy link
Owner

benbowes commented Jun 3, 2020

Great please do that. I am pretty interested in tsdx

@benbowes
Copy link
Owner

benbowes commented Jun 3, 2020

Just tried out TSDX in a much simpler project benbowes/singleline#9

It is awesome

@benbowes
Copy link
Owner

benbowes commented Jun 5, 2020

@alanrsoares I am super keen for this to happen now, having had a few goes with tsdx - thanks heaps for bringing this up!

I noticed that you have not forked this repo. This makes me think that you are not in the process of converting this over to tsdx yourself.

So I'm attempting to do this over the next few days - using the storybook preset. If you are in progress though, and want to do it let me know, otherwise I will ping you on a PR.

@alanrsoares
Copy link
Author

Hey @benbowes. Sorry for the lack of response from my end. It's been a pretty hectic week at work. Feel free to jump it now that you more familiar with tsdx. I can definitely help reviewing the PR though.

@benbowes
Copy link
Owner

benbowes commented Jun 5, 2020

StoryBook is annoying me. As a developer I just want to know how to use a thing.

@benbowes
Copy link
Owner

Made a bit of progress in another repo on this https://github.com/benbowes/react-responsive-select-next/

New styleguidist docs here: https://benbowes.github.io/react-responsive-select-next/
Published to npm here: https://www.npmjs.com/package/react-responsive-select-next

More to do

@benbowes
Copy link
Owner

see #150

@benbowes
Copy link
Owner

released in 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants