Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replacement paths that are absolute paths on Windows #13

Closed
wants to merge 3 commits into from
Closed

Fix replacement paths that are absolute paths on Windows #13

wants to merge 3 commits into from

Commits on Jul 24, 2014

  1. Fix replacement paths that are absolute paths on Windows 

    There is a bug where absolute paths have their backslashes replaced as forward slashes.  For relative paths, this is not a problem.  However, especially with joeybaker/remapify, it is possible to have absolute paths passed into aliasify, and getting the backslashes replaced there is problematic.

This fixes the issue by testing for an absolute path on Windows, and then replacing backslashes with double backslashes, which is necessary since the filename is in quotes.  All other paths have their backslashes replaced by forward slashes as currently happens today.
    @roncli
    roncli committed Jul 24, 2014
    Configuration menu
    Copy the full SHA
    c66562d View commit details
    Browse the repository at this point in the history

  2. Fix replacement

    @roncli
    roncli committed Jul 24, 2014
    Configuration menu
    Copy the full SHA
    d4af89e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2014

  1. Add absolute path resolution test.

    @roncli
    roncli committed Jul 25, 2014
    Configuration menu
    Copy the full SHA
    7bff5df View commit details
    Browse the repository at this point in the history