Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #24 search - display a message when there's no results #60

Merged

Conversation

MattGreyDesign
Copy link
Contributor

Adds #24 enhancement

image

@MattGreyDesign MattGreyDesign changed the title #24 search - display a message when there's no results PR #24 search - display a message when there's no results Dec 20, 2017
@benbrignell
Copy link
Owner

Oh man, this is perfect. Thanks.

@benbrignell benbrignell merged commit c9188bb into benbrignell:master Dec 20, 2017
@benbrignell
Copy link
Owner

@MattGreyDesign Hey this seems to work locally but on production search isn't working. I can't see why. Any ideas?

@benbrignell benbrignell mentioned this pull request Dec 21, 2017
@benbrignell
Copy link
Owner

Ignore that @MattGreyDesign all is good - I had a brainwave and disabled js minification and cleared server cache and it works fine. Sorry to bother you - either the old index.js was still cached or the minification was breaking something, will inspect in the morning.

@MattGreyDesign
Copy link
Contributor Author

@benbrignell What does the minification run through? I can't seem to find anything in the pipeline, is it a post-script?

@benbrignell
Copy link
Owner

It's done by Cloudflare, I think it stripped out the frontmatter at the top

---

---

@MattGreyDesign
Copy link
Contributor Author

So long as it minifies after Jekyll has compiled it shouldn't be too much of a problem as those are stripped from the built .js file. If that is the issue you can always hardcode the contribution url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants