Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NoJS - Another little tweak #510

Closed
gripped opened this issue Oct 30, 2021 · 0 comments · Fixed by #511
Closed

[BUG] NoJS - Another little tweak #510

gripped opened this issue Oct 30, 2021 · 0 comments · Fixed by #511
Labels
bug Something isn't working

Comments

@gripped
Copy link
Contributor

gripped commented Oct 30, 2021

I imagine the css nojs_link['style'] = 'display:block;width:100%;' line was there to help with the <hr> which used to exist?

Some search result sections have multiple links inline at the bottom (and some in a list as well) ie.
1

Using NoJS splits them (as it before the last PR, but to greater effect before)
without

With the css removed it's better
with

Another example
Standard
github-clean
NoJS
githubwithout
CSS removed
github

You may differ but I think it looks much better without the css?
I've tested various queries and can find no ill effect with the change.

@gripped gripped added the bug Something isn't working label Oct 30, 2021
@gripped gripped mentioned this issue Oct 30, 2021
benbusby pushed a commit that referenced this issue Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant