Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block title or url by regex #473

Merged
merged 7 commits into from
Oct 21, 2021
Merged

feat: block title or url by regex #473

merged 7 commits into from
Oct 21, 2021

Conversation

YadominJinta
Copy link
Contributor

Block results by title or url using regex.
This fix #472.

benbusby
benbusby requested changes Oct 19, 2021
View reviewed changes
Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small requests, otherwise looks good. Thanks!

app/static/settings/translations.json Outdated Show resolved Hide resolved
app/filter.py Outdated Show resolved Hide resolved
@YadominJinta
Copy link
Contributor Author

I use Google translate and it may not be correct 🙏

benbusby
benbusby approved these changes Oct 21, 2021
View reviewed changes
Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just fixed up some PEP-8 issues since that was the only problem.

@benbusby benbusby merged commit 284a810 into benbusby:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbusby benbusby benbusby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Advanced Block Rules
2 participants
@YadominJinta @benbusby