Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty baseurl to host site at root of web server #15

Merged

Conversation

andrewkroh
Copy link
Contributor

Thanks for the template. I am new to Jekyll so it's possible this is not a bug, but user error.

  • Changed code such that baseurl can set to an empty value if you are hosting site at the root of a web server.
  • Made Facebook and twitter protocols optional.
  • Removed tabs. (should have done this in a separate PR, sorry)

…osting site at the root of a web server.

Made Facebook and twitter protocols optional.
Removed tabs.
@andrewkroh andrewkroh force-pushed the bugfix/double-slash-social-url branch from 9be429f to 8ba047d Compare November 8, 2015 20:07
@andrewkroh andrewkroh changed the title Removing double slashes from social URLs when baseurl is '/'. Allow empty baseurl to host site at root of web server Nov 8, 2015
@bencentra
Copy link
Owner

👍 I definitely think this is the right way to handle /'s in URLs. I tested it locally with an empty baseurl and a baseurl of "/centrarium", and all the assets and pages loaded properly.

bencentra added a commit that referenced this pull request Nov 22, 2015
Allow empty baseurl to host site at root of web server
@bencentra bencentra merged commit 95aee1a into bencentra:master Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants