memory-notes

bencheeorg · Dec 13, 2023 · 63a5c5e · 63a5c5e
1 parent dfa6987
commit 63a5c5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/benchee/formatter.ex b/lib/benchee/formatter.ex
@@ -153,6 +153,7 @@ defmodule Benchee.Formatter do
   # the results of that formatting are written in sequence.
   defp parallel_output(suite, module_configurations) do
     module_configurations
+    # clean up the suite
     |> Parallel.map(fn {module, options} -> {module, options, module.format(suite, options)} end)
     |> Enum.each(fn {module, options, output} -> module.write(output, options) end)
 

diff --git a/lib/benchee/statistics.ex b/lib/benchee/statistics.ex
@@ -169,6 +169,9 @@ defmodule Benchee.Statistics do
 
     update_in(suite.scenarios, fn scenarios ->
       Parallel.map(scenarios, fn scenario ->
+        # send only the samples, percentiles and whatevs along
+        # be mindful that we might (soon (tm)) pass on the sample size from here as well
+        # theoretically we could only pass on collection_data
         calculate_scenario_statistics(scenario, percentiles)
       end)
     end)