Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for memory measurement on OTP 18 #198

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Conversation

devonestes
Copy link
Collaborator

This way folks won't think things just aren't working, and will know to
upgrade their version of OTP to something newer.

Resolves #194

@PragTob
Copy link
Member

PragTob commented Mar 13, 2018

Credo strikes again!

  Code Readability                                                              
┃ 
┃ [R] ↓ Do not use parentheses when defining a function which has no arguments.
┃       lib/benchee/configuration.ex:336 #(Benchee.Configuration.print_memory_measure_warning)
Please report incorrect results: https://github.com/rrrene/credo/issues
Analysis took 1.7 seconds (0.05s to load, 1.6s running checks)
331 mods/funs, found 1 code readability issue.
The command "mix credo --strict" exited with 4.

Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good save the credo error... I quickly thought if we were duplicating the logic but it's not the same so we're golden I think ⭐

This way folks won't think things just aren't working, and will know to
upgrade their version of OTP to something newer.
@devonestes devonestes merged commit ec0facf into master Mar 14, 2018
@devonestes devonestes deleted the warn-memory-otp-18 branch March 14, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants