Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce relative_statistics to take loaded scenarios into account #289

Merged
merged 7 commits into from Mar 28, 2019

Conversation

PragTob
Copy link
Member

@PragTob PragTob commented Mar 27, 2019

  • fixes Comparison broken when saving and loading #287
  • Sadly introduces another step into the verbose interface but
    there is really no other way to make it work with loading
    scenarios the way we want it to work... or well yeah there
    are other ways but this seems to be the nicest and even before
    I thought about doing it in a separate step and the code is
    also completely separate/easy to extract and tests are easier
    to setup. So I see this as a win.

@PragTob PragTob force-pushed the save-and-load-and-relative-statistics branch from 5ccc57b to f5233ee Compare March 27, 2019 11:06
* fixes #287
* Sadly introduces another step into the verbose interface but
  there is really no other way to make it work with loading
  scenarios the way we want it to work... or well yeah there
  are other ways but this seems to be the nicest and even before
  I thought about doing it in a separate step and the code is
  also completely separate/easy to extract and tests are easier
  to setup. So I see this as a win.
* smaller data structure --> less execution time --> smaller
  chance of it going so long that it doesn't get to memory
  measrements
* also more memory time to see that it works
@PragTob PragTob force-pushed the save-and-load-and-relative-statistics branch from 1eecb9f to 2164652 Compare March 28, 2019 08:44
@PragTob PragTob merged commit 9351312 into master Mar 28, 2019
@PragTob PragTob deleted the save-and-load-and-relative-statistics branch March 28, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison broken when saving and loading
1 participant